test: 82% coverage on blocks #3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
| u.Debug = true | ||
|
|
||
| block, err = NewBlockWithHash(data, hash) | ||
| if err == nil { |
There was a problem hiding this comment.
I'd prefer to explicitly check errors in cases like this. I've had a few instances of tests passing while the code itself was breaking because a different error was being returned
|
One comment, otherwise LGTM |
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@ipfs.io>
| @@ -11,6 +11,8 @@ import ( | |||
| u "gx/ipfs/QmZNVWh8LLjAavuQ2JXuFmuYH3C11xo988vSgp7UQrTRj1/go-ipfs-util" | |||
| ) | |||
|
|
|||
| var errWrongHash = errors.New("Data did not match given hash!") | |||
There was a problem hiding this comment.
export this for checking against outside of this package
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
|
Exposed. |
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
|
@whyrusleeping this is done, I just re-run travis tests, as at the time OSX tests were failing everywhere. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Jakub Sztandera kubuxu@protonmail.ch