ipfs/cat: disable auto-gc check #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
whyrusleeping
force-pushed
the
feat/disable-cat-gc
branch
from
82ffa86
to
115bee5
Compare
|
LGTM, it would be good to have a comment there but it isn't required. |
| return | ||
| } | ||
| */ | ||
|
|
There was a problem hiding this comment.
This could have just been removed. We have git history and the changelog, and this code isn't really complicated enough to keep it for future reference :)
There was a problem hiding this comment.
Yeah... youre probably right.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality currently isnt very useful or reliable. Disabling it temporarily until we can refine the underlying code.
License: MIT
Signed-off-by: Jeromy why@ipfs.io