Directly Fix #2839 #3135
Merged
Directly Fix #2839 #3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org>
kevina
added
need/review
| ' | ||
|
|
||
| test_expect_success "output looks good" ' | ||
| echo "QmWYN8SEXCgNT2PSjB6BnxAx6NJQtazWoBkTRH9GRfPFFQ" > badlink_exp && | ||
| test_cmp badlink_exp badlink_out | ||
| ' | ||
|
|
||
| test_expect_success "adding with symlink in middle of path is same as\ | ||
| adding with no symlink" ' |
There was a problem hiding this comment.
This test should still be valid.
kevina
force-pushed
the
kevina/2839directfix
branch
from
5f503e6
to
802d3f9
Compare
|
Alright, This LGTM. @jbenet since this is in response to your review, want to give it a quick look over? |
|
LGTM |
|
Thanks @kevina! |
|
So, just to be clear, would we be able to make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the original fix for #2839 and instead fix the original issue so that adding the current directory works as expected without changing the semantics of how symbolic links are handled.