dag get should be a read only command #3499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
reviewed
Dec 13, 2016
| @@ -6,6 +6,7 @@ import ( | |||
|
|
|||
| cmds "github.com/ipfs/go-ipfs/commands" | |||
| dag "github.com/ipfs/go-ipfs/core/commands/dag" | |||
| dcmd "github.com/ipfs/go-ipfs/core/commands/dag" | |||
There was a problem hiding this comment.
It is already imported line above.
added CmdDagGet to the read only command set. tried to add a test, but dag get needs tests in general License: MIT Signed-off-by: Juan Batiz-Benet
whyrusleeping
force-pushed
the
dag-get-ro
branch
from
3d24d75
to
bb85dd9
Compare
|
commit message is valid, duplicate import fixed, this LGTM |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added CmdDagGet to the read only command set.
tried to add a test, but dag get needs tests in general