Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for recursively pinning a dag (i.e. large file). #3691

Merged
merged 1 commit into from
Feb 15, 2017

Conversation

kevina
Copy link
Contributor

@kevina kevina commented Feb 15, 2017

Test for already fixed #3688

License: MIT
Signed-off-by: Kevin Atkinson k@kevina.org

License: MIT
Signed-off-by: Kevin Atkinson <k@kevina.org>
@kevina kevina added status/in-progress In progress need/review Needs a review and removed status/in-progress In progress labels Feb 15, 2017
@kevina
Copy link
Contributor Author

kevina commented Feb 15, 2017

@Kubuxu there is no way this could decrease coverage. It only adds test!

Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, LGTM. Thanks @kevina

@whyrusleeping
Copy link
Member

Codecov sensed a disturbance in the cov, as if hundreds of lines were suddenly untested.

@whyrusleeping whyrusleeping merged commit c98e203 into master Feb 15, 2017
@whyrusleeping whyrusleeping deleted the kevina/pin-tests branch February 15, 2017 22:29
@kevina kevina mentioned this pull request Feb 15, 2017
@Kubuxu
Copy link
Member

Kubuxu commented Feb 15, 2017

For some reason pubsub was suddenly not tested.

@kevina
Copy link
Contributor Author

kevina commented Feb 15, 2017

@Kubuxu, note #3693. I did accidentally remove a test. :(

@Kubuxu Kubuxu added this to the ipfs 0.4.6 milestone Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/review Needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ipfs pin add does not fetch raw leaves and thus pins incomplete dag
3 participants