Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove broken spdy multiplexer and enable multiplex by default as second option #3725

Merged
merged 1 commit into from
Mar 2, 2017

Conversation

dignifiedquire
Copy link
Member

  • spdystream is not fully spdy spec compatible, creating issues when
    doing interop with js, so it is removed
  • muliplex is working well now in interop with js, so being enabled by
    default

This means the new default muxers are yamux,mplex

@whyrusleeping
Copy link
Member

@dignifiedquire fix your commit signature

Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets leave the command line flag in, so that users can disable it if they want (im still considering it experimental). Lets also do something like:

if os.Getenv("IPFS_ENABLE_SPDY") == "true" {
  // add spdy muxer
}

So that it becomes easier to test this if we get around to fixing the go spdy implementation. (which i think is something we want to do eventually? or maybe replace it with http2, idk, probably can keep the spdy stuff removed)

Yeah, disregard the bit about spdy.

@whyrusleeping whyrusleeping added this to the Ipfs 0.4.7 milestone Feb 24, 2017
@dignifiedquire
Copy link
Member Author

what's wromg with it? I already pushed a fix with the license stuff

@dignifiedquire
Copy link
Member Author

@whyrusleeping I think I did what you want

Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dignifiedquire

License: MIT
Signed-off-by: Friedel <dignifiedquire@gmail.com>
@whyrusleeping whyrusleeping merged commit d2f41e2 into master Mar 2, 2017
@whyrusleeping whyrusleeping deleted the feat/better-muxer branch March 2, 2017 17:15
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Mar 2, 2017
@Kubuxu
Copy link
Member

Kubuxu commented Mar 2, 2017

This should have, but did not remove spdy from package.json. I will handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants