-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove broken spdy multiplexer and enable multiplex by default as second option #3725
Conversation
c0a83ac
to
d61fbdc
Compare
@dignifiedquire fix your commit signature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets leave the command line flag in, so that users can disable it if they want (im still considering it experimental). Lets also do something like:
if os.Getenv("IPFS_ENABLE_SPDY") == "true" {
// add spdy muxer
}
So that it becomes easier to test this if we get around to fixing the go spdy implementation. (which i think is something we want to do eventually? or maybe replace it with http2, idk, probably can keep the spdy stuff removed)
Yeah, disregard the bit about spdy.
what's wromg with it? I already pushed a fix with the license stuff |
d61fbdc
to
95de0ca
Compare
@whyrusleeping I think I did what you want |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @dignifiedquire
95de0ca
to
d599884
Compare
License: MIT Signed-off-by: Friedel <dignifiedquire@gmail.com>
d599884
to
8b2aa56
Compare
This should have, but did not remove spdy from package.json. I will handle it. |
doing interop with js, so it is removed
default
This means the new default muxers are
yamux,mplex