Make Golint happy in the blocks submodule. #3827
Merged
+149
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has required changing the order of some parameters and adding HashOnRead to the Blockstore interface (which I have in turn added to all the wrapper implementations). License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
|
codeclimate is a troll |
Kubuxu
reviewed
Mar 24, 2017
| @@ -11,16 +12,20 @@ import ( | |||
| mh "gx/ipfs/QmbZ6Cee2uHjG7hf19qLHppgKDRtaG4CVtMzdmK9VCVqLu/go-multihash" | |||
| ) | |||
|
|
|||
| var ErrWrongHash = errors.New("data did not match given hash!") | |||
| // ErrWrongHash is returned when the Cid of a block is not the expected | |||
| // according to the contents. It is currently used only when debugging. | |||
There was a problem hiding this comment.
I think it is also used when HashOnRead is on.
There was a problem hiding this comment.
That uses ErrHashMismatch = errors.New("block in storage has different hash than requested") in the blockstore module...
There was a problem hiding this comment.
Ok, let's leave it as it is we might want to merge those errors in future. I must have not noticed it when I were writing the HashOnRead code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has required changing the order of some parameters and
adding HashOnRead to the Blockstore interface (which I have in turn
added to all the wrapper implementations).
I plan to do more, but let's merge little by little, submodule by submodule.