WIP: add PeerID lookup #3882
Merged
WIP: add PeerID lookup #3882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enhance key lookup logic and enable PeerID lookup in addition to the key name License: MIT Signed-off-by: Kerem Gocen <keremgocen@gmail.com>
Kubuxu
reviewed
Apr 27, 2017
core/commands/publish.go
Outdated
| func keylookup(k string, n *core.IpfsNode) (crypto.PrivKey, error) { | ||
|
|
||
| res, err := n.GetKey(k) | ||
| if res != nil { |
There was a problem hiding this comment.
I would check here if error is different than ErrNoSuchKey if that is a case It signals different error than should happen here.
Kubuxu
reviewed
Apr 27, 2017
core/commands/publish.go
Outdated
| @@ -176,3 +181,36 @@ func publish(ctx context.Context, n *core.IpfsNode, k crypto.PrivKey, ref path.P | |||
| Value: ref.String(), | |||
| }, nil | |||
| } | |||
|
|
|||
| func keylookup(k string, n *core.IpfsNode) (crypto.PrivKey, error) { | |||
There was a problem hiding this comment.
Please make the Node first argument.
change core.IpfsNode as first arg check keylookup err to propagate validation errors from lower levels License: MIT Signed-off-by: Kerem Gocen <keremgocen@gmail.com>
keremgocen
force-pushed
the
fix-cmd-key-peerid
branch
from
f93e8c5
to
76e227d
Compare
|
No, force pushes are OK. |
test for `ipfs name publish` using PeerID as key name License: MIT Signed-off-by: Kerem Gocen <keremgocen@gmail.com>
keremgocen
force-pushed
the
fix-cmd-key-peerid
branch
from
05939e2
to
fca98ae
Compare
|
Do you have any recommendations for fixing the failing CI here? Also a review is required to proceed this one forward I see. |
|
@keremgocen don't worry about travis too much (it likes to fail on its own, we load their machines a bit too much). |
whyrusleeping
approved these changes
May 20, 2017
|
@Kubuxu 👍 here? |
Kubuxu
approved these changes
May 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #3807
License: MIT
Signed-off-by: Kerem Gocen keremgocen@gmail.com