Add Suborigin header to gateway responses #3914
Conversation
jes
force-pushed
the
master
branch
2 times, most recently
from
b8bdc0b
to
9a76674
Compare
core/corehttp/gateway_handler.go
Outdated
| // | ||
| // NOTE: This is not yet widely supported by browsers. | ||
| if !ipnsHostname { | ||
| // e.g.: 0="ipfs.io", 1="ipfs", 2="QmYuNaKwY...", ... |
There was a problem hiding this comment.
Part 0 is simply empty, urlPath is something like /ipfs/QmFoo/a/b.
core/corehttp/gateway_handler.go
Outdated
| if !ipnsHostname { | ||
| // e.g.: 0="ipfs.io", 1="ipfs", 2="QmYuNaKwY...", ... | ||
| pathComponents := strings.SplitN(urlPath, "/", 4) | ||
| suboriginRaw := []byte(strings.ToLower(pathComponents[2])) |
There was a problem hiding this comment.
This isn't right. You can't 'ToLower' encoded value as it will change the IPFS hash.
There was a problem hiding this comment.
I guess the code isn't clear enough -- this part handles the /ipns/EXAMPLE.COM/ case; when the second part will decode as base58, it is handled accordingly. I'll add a comment to explain this.
There was a problem hiding this comment.
Ahh, I missed that. Yeah, it is better not to be clever in places like that.
This existed before but was disabled in 912a972 because the Suborigin spec changed and it became incompatible. This commit updates the generated Suborigin header to be conformant with the latest spec. License: MIT Signed-off-by: James Stanley <james@incoherency.co.uk>
|
|
||
| base32Encoded, err := multibase.Encode(multibase.Base32, suboriginRaw) | ||
| if err != nil { | ||
| internalWebError(w, err) |
There was a problem hiding this comment.
This should be a 4xx error via webError(), probably just 400 Bad Request. It's an error that can only be recovered from by altering the request.
There was a problem hiding this comment.
I don't see how base32 encoding can fail -- if it does, surely that's an internal server error, and nothing to do with the client?
There was a problem hiding this comment.
Mh -- yeah in this case the error can only come from an unsupported encoding parameter: https://github.com/multiformats/go-multibase/blob/master/multibase.go
LGTM then 👍
This existed before but was disabled in 912a972 because the Suborigin spec
changed and it became incompatible.
This commit updates the generated Suborigin header to be conformant with the
latest spec.
Thank you Stskeeps, Kubuxu, and TUSF on IRC for holding my hand with this.