update to dht code with provide announce option #3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
feat/provide-ann-opt
branch
from
420d40f
to
0418930
Compare
Kubuxu
approved these changes
May 24, 2017
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
update to dht code with provide announce option This commit was moved from ipfs/kubo@4cf046c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the dht dependency to one that gives us the option of whether or not to actually broadcast to the network with each call to provide. The option is set to 'true' in all options, retaining the current behaviour of ipfs.
Further integration will need to be done to make proper use of this. My current thought it to have all calls by bitswap provide with no announcement, then in each command that currently pulls and provides content (add, refs, pin, etc) we have an option, default true, that recursively provides the content after the operation has completed.
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com