Add CID Codecs to block put #4022
Conversation
|
Force pushed an updated with a more decent commit message 😬 |
|
@whyrusleeping should we hard code every cid type into go-ipfs? It seams to me we should use a lookup table from an external library. Was this discussed somewhere else? |
|
Good point @kevina @whyrusleeping, as |
|
Yeah, we should add a lookup table. Someone want to PR that into go-cid?
…On Thu, Jun 29, 2017, 00:33 Herman Junge ***@***.***> wrote:
Good point @kevina <https://github.com/kevina> @whyrusleeping
<https://github.com/whyrusleeping>, as mhtype does have a lookup table (
https://github.com/hermanjunge/go-ipfs/blob/c19f1bca895cbab264a6025f5d792616bb0ecb86/core/commands/block.go#L195
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4022 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABL4HIv2-DCl8V9qU5ay38V5Msh8cVn0ks5sIykFgaJpZM4OIvol>
.
|
|
@whyrusleeping will do. Let's close this meanwhile. |
ghost
closed this
|
Once merged, I rebase this PR. |
ghost
reopened this
|
@hsanjuan you should be unblocked now, the go-cid package has been updated in master |
Adding codecs found in Use the codec map implemented in ipfs/go-cid#26 License: MIT Signed-off-by: Herman Junge <chpdg42@gmail.com>
|
@whyrusleeping you meant to mention @hermanjunge right ? :) |
|
Heh, yes i did. I guess my brain saw "oh, theres a j in the middle of that username that starts with an h, thats the right one" |
Adding codecs found in https://github.com/ipfs/go-cid/blob/b42583c8bfdafac9965f450294b371d1b734c6f6/cid.go#L67-L79