Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Require go 1.8 #4044

Merged
merged 1 commit into from
Jul 7, 2017
Merged

docs: Require go 1.8 #4044

merged 1 commit into from
Jul 7, 2017

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Jul 6, 2017

Closes #4043

@Kubuxu Kubuxu added the status/in-progress In progress label Jul 6, 2017
@whyrusleeping
Copy link
Member

I'll need to push another release of gx and gx-go for this. (gx-go asserts that it was compiled with the sufficient version of go due to changes in the stdlib ast parsing changing between versions)

@Kubuxu
Copy link
Member

Kubuxu commented Jul 6, 2017

You also have to fix build systems.
I will fix Jenkins as it is a bit more complex.

@Kubuxu Kubuxu assigned Kubuxu and magik6k and unassigned Kubuxu Jul 6, 2017
@Kubuxu
Copy link
Member

Kubuxu commented Jul 6, 2017

Jenkins runs Go 1.8 already.

@whyrusleeping
Copy link
Member

i released new version of gx (0.12.0) and gx-go (1.5.0), update bin/Rules.mk to use these new versions

License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@whyrusleeping whyrusleeping merged commit 867f9c1 into master Jul 7, 2017
@whyrusleeping whyrusleeping deleted the docs/go1.8 branch July 7, 2017 19:32
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Jul 7, 2017
@magik6k magik6k added this to the Ipfs 0.4.11 milestone Aug 13, 2017
@magik6k magik6k restored the docs/go1.8 branch November 27, 2017 03:34
@magik6k magik6k deleted the docs/go1.8 branch November 27, 2017 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants