Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove dead godep, gobuilder, and equinox stuff #4357

Merged
merged 2 commits into from
Nov 3, 2017

Conversation

ghost
Copy link

@ghost ghost commented Oct 31, 2017

No description provided.

Lars Gierth added 2 commits October 30, 2017 12:16
License: MIT
Signed-off-by: Lars Gierth <larsg@systemli.org>
License: MIT
Signed-off-by: Lars Gierth <larsg@systemli.org>
@ghost ghost added the topic/cleanup Topic cleanup label Oct 31, 2017
@ghost ghost self-assigned this Oct 31, 2017
@ghost ghost added the status/in-progress In progress label Oct 31, 2017
@whyrusleeping
Copy link
Member

The best kind of PR

@whyrusleeping
Copy link
Member

strange test failure on travis sharness though:

Error: Unrecognized file type for named-pipe: prw-rw-r--
USAGE
  ipfs add <path>... - Add a file or directory to ipfs.
  ipfs add [--recursive | -r] [--quiet | -q] [--quieter | -Q] [--silent] [--progress | -p] [--trickle | -t] [--only-hash | -n] [--wrap-with-directory | -w] [--hidden | -H] [--chunker=<chunker> | -s] [--pin=false] [--raw-leaves] [--nocopy] [--fscache] [--cid-version=<cid-version>] [--hash=<hash>] [--] <path>...
Use 'ipfs add --help' for more information about this command.
ok 189 - useful error message when adding a named pipe�(B�[m

�[36mexpecting success: 
    mkdir -p named-pipe-dir &&
    mkfifo named-pipe-dir/named-pipe &&
    STAT=$(generic_stat named-pipe-dir/named-pipe) &&
    test_expect_code 1 ipfs add -r named-pipe-dir 2>actual &&
    printf "Error:$err_prefix Unrecognized file type for named-pipe-dir/named-pipe: $STAT\n" >expected &&
    rm named-pipe-dir/named-pipe &&
    rmdir named-pipe-dir &&
    test_cmp expected actual
  �(B�[m
> diff -u expected actual
--- expected	2017-10-31 02:51:32.284212129 +0000
+++ actual	2017-10-31 02:51:32.284212129 +0000
@@ -1 +1 @@
-Error: Post http://127.0.0.1:42296/api/v0/add?encoding=json&progress=true&r=true&stream-channels=true: Unrecognized file type for named-pipe-dir/named-pipe: prw-rw-r--
+Error: Post http://127.0.0.1:42296/api/v0/add?encoding=json&progress=true&r=true&stream-channels=true: read tcp 127.0.0.1:50466->127.0.0.1:42296: use of closed network connection

�[1m�[31mnot ok 190 - useful error message when recursively adding a named pipe�(B�[m
#	
#	    mkdir -p named-pipe-dir &&
#	    mkfifo named-pipe-dir/named-pipe &&
#	    STAT=$(generic_stat named-pipe-dir/named-pipe) &&
#	    test_expect_code 1 ipfs add -r named-pipe-dir 2>actual &&
#	    printf "Error:$err_prefix Unrecognized file type for named-pipe-dir/named-pipe: $STAT
#	" >expected &&
#	    rm named-pipe-dir/named-pipe &&
#	    rmdir named-pipe-dir &&
#	    test_cmp expected actual
#	

@Kubuxu
Copy link
Member

Kubuxu commented Nov 1, 2017

@whyrusleeping it looks not connected with this, lets open an issue and merge this

@whyrusleeping whyrusleeping merged commit 4257eba into master Nov 3, 2017
@ghost ghost removed the status/in-progress In progress label Nov 3, 2017
@whyrusleeping whyrusleeping deleted the feat/remove-dead-code branch November 3, 2017 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/cleanup Topic cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants