core: get cmd outPath remove trailing slash - fixes #3729 #4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamliesko
changed the title
adamliesko
changed the title
|
Hey @adamliesko, Thanks for the PR! Sorry for the delay, We will get to this as soon as the 0.4.13 patch release gets finalized in a day or so. |
Kubuxu
approved these changes
Nov 16, 2017
|
Hey @adamliesko, Could you rebase this for us and fix the merge conflict? |
|
cc @keks in case theres any weirdness since the commands lib extraction |
When using path with trailing slashes, ipfs get command had issues with trying to store content into '.' folder (as the file part of the path was empty). Now, it correctly stores the file into desired folder, thanks to the removal of trailing slash by introducing a getOutPath function in get command, which does proper parsing Of the output path. BEFORE: $ .pfs get /ipns/multiformats.io/ Saving file(s) to . NOW: $ ./ipfs get /ipns/multiformats.io/ Saving file(s) to multiformats.io License: MIT Signed-off-by: adamliesko <adamliesko@gmail.com>
|
Sure @whyrusleeping, I rebased but Jenkins still isn't happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes issue #3729.
When using path with trailing slashes, ipfs get command had issues with trying to store content into '.' folder (as the file part of the path was empty). Now, it correctly stores the file into desired path,
thanks to the removal of trailing slash by introducing a getOutPath function in get command, which does proper parsing of the output path.
BEFORE:
NOW: