Fix two race conditions (and possibly go routine leaks) in commands #4406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
(segfault) Also, buffer the response channel. I believe we had a go routine leak here before. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
I believe this also fixes a potential go routine leak (on race). License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
keks
approved these changes
Nov 21, 2017
| type pinResult struct { | ||
| pins []*cid.Cid | ||
| err error | ||
| } |
There was a problem hiding this comment.
Huh, I did not know you could define types in functions. Neat!
There was a problem hiding this comment.
You want to have some real fun?
ch := make(chan struct{pins []*cid.Cid, err error}, 1)
//...
ch <- struct{pins []*cid.Cid, err error}{err: errors.New("😎")}
There was a problem hiding this comment.
I have some other trick for you:
type System struct {
cntrSafe struct {
sync.Mutex
n int
}
mapSafe struct {
sync.Mutex
m map[int]int
}
}usage
s := &System{}
s.cntrSafe.Lock()
s.cntrSafe.n++
s.cntrSafe.Unlock()
Kubuxu
approved these changes
Nov 21, 2017
whyrusleeping
approved these changes
Nov 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4405