Fix various IPNS issues #4440
Merged
Fix various IPNS issues #4440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We republish every 4 hours, not 12. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
(after a delay of 1 minute) License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
This way, if we *happen* to be offline while attempting a publish, we don't wait the full interval. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
(makes code climate happy) License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ghost
assigned License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
vyzo
reviewed
Nov 30, 2017
| defer tick.Stop() | ||
| timer := time.NewTimer(InitialRebroadcastDelay) | ||
| defer timer.Stop() | ||
| if rp.Interval < InitialRebroadcastDelay { |
There was a problem hiding this comment.
Doesn't this defeat the purpose of the initial delay?
I think we should simply tick with the InitialRebroadcastDelay unconditionally here.
There was a problem hiding this comment.
The initial delay is usually much shorter than the interval. If the user asks us to, e.g., publish every 10s, IMO, we should do that regardless of the initial delay (at the moment, not doing that would break the tests).
Alternatively, we could make the initial delay configurable (but that's one more knob).
There was a problem hiding this comment.
Yeah that's reasonable -- no need to have another knob for this.
vyzo
approved these changes
Dec 1, 2017
whyrusleeping
approved these changes
Dec 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while looking into: https://discuss.ipfs.io/t/ipfs-name-failing-to-resolve/1524