bitswap nits #4458
Merged
bitswap nits #4458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
magik6k
approved these changes
Dec 5, 2017
|
Test fail on Jenkins looks unrelated: |
Stebalien
force-pushed
the
fix/bitswap-nits
branch
from
d69697d
to
e985975
Compare
Stebalien
commented
Dec 5, 2017
| @@ -372,16 +372,6 @@ func (bs *Bitswap) ReceiveMessage(ctx context.Context, p peer.ID, incoming bsmsg | |||
| return | |||
| } | |||
|
|
|||
| // quickly send out cancels, reduces chances of duplicate block receives | |||
| var keys []*cid.Cid | |||
There was a problem hiding this comment.
@whyrusleeping this code was dead. We're currently sending out cancels from within sessions. However, this does mean that the above comment is no longer correct (it'll likely take a bit longer to send out cancels).
|
This should hopefully make gc a bit happier when bitswapping. |
Avoids lots of reallocations under a lock. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Also, don't call time.Now in a loop. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
force-pushed
the
fix/bitswap-nits
branch
from
e985975
to
93151d4
Compare
| @@ -336,12 +337,12 @@ func (e *Engine) numBytesReceivedFrom(p peer.ID) uint64 { | |||
| // ledger lazily instantiates a ledger | |||
| func (e *Engine) findOrCreate(p peer.ID) *ledger { | |||
| e.lock.Lock() | |||
| defer e.lock.Unlock() | |||
There was a problem hiding this comment.
I do want to note that this may cause a perf degradation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.