Add offset option to cat command #4538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
core/commands/cat.go
Outdated
| if err != nil { | ||
| return nil, 0, err | ||
| } | ||
| offset = offset - count |
There was a problem hiding this comment.
shouldnt this always result in offset being 0?
test/sharness/t0040-add-and-cat.sh
Outdated
| test_cmp expected actual | ||
| ' | ||
|
|
||
| test_expect_success "ipfs cat multipule hashes with offset succeeds" ' |
|
a couple things, then LGTM. |
frrist
force-pushed
the
feat/command/cat-offset
branch
2 times, most recently
from
bc17543
to
2fcfbd8
Compare
Allow an offset option to be passed to cat command License: MIT Signed-off-by: ForrestWeston <forrest@protocol.ai>
License: MIT Signed-off-by: ForrestWeston <forrest@protocol.ai>
frrist
force-pushed
the
feat/command/cat-offset
branch
from
2fcfbd8
to
8a8c9b5
Compare
whyrusleeping
approved these changes
Jan 2, 2018
Stebalien
approved these changes
Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.