Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand the issue template and remove the severity field #4624

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

Stebalien
Copy link
Member

  • Direct users seeking support to the forums.
  • Remove the severity field. It doesn't actually help (especially because we can't filter by it and, anyways, we end up deciding the severity).
  • Put the section comments inside the sections. This has been annoying me from day 1.
  • Put the welcome text at the top so users actually read it.
  • Expand on what we want in a description.

* Direct users seeking support to the forums.
* Remove the severity field. It doesn't actually help (especially because we
  can't filter by it and, anyways, *we* end up deciding the severity).
* Put the section comments *inside* the sections. This has been annoying me from
  day 1.
* Put the welcome text *at the top* so users actually read it.
* Expand on what we want in a description.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost assigned Stebalien Jan 29, 2018
@ghost ghost added the status/in-progress In progress label Jan 29, 2018
@Stebalien Stebalien requested a review from kevina January 29, 2018 23:34
Copy link
Contributor

@kevina kevina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not convinced removing the Severity field is a good idea and would like others feedback on that.

Other than that LGTM.

@Stebalien
Copy link
Member Author

Stebalien commented Jan 30, 2018

I am not convinced removing the Severity field is a good idea and would like others feedback on that.

I've literally never found it useful (not even for the entertainment value). From reading the issue, I can tell how sever it is. Without reading the issue, I can't trust the severity field.

IMO, severity is better handled through labels anyways (searchable, easy to see, not set by the reporter). I wonder if it's possible to give labeling permission to contributors.

(Although I may just be getting curmudgeonly)

@kevina
Copy link
Contributor

kevina commented Jan 30, 2018

IMO, severity is better handled through labels anyways (searchable, easy to see, not set by the reporter). I wonder if it's possible to give labeling permission to contributors.

I agree. Not sure about the possibility of giving labeling permission to contributors.

@Stebalien
Copy link
Member Author

I agree. Not sure about the possibility of giving labeling permission to contributors.

Fine grained permissions? GitHub? Silly me. We'd have to use a bot.

@whyrusleeping
Copy link
Member

jenkins fails for some reason? Want to file that as an issue?

@kevina
Copy link
Contributor

kevina commented Jan 31, 2018

Since we decided to remove the Severity field we also need to fix https://github.com/ipfs/go-ipfs/blob/master/docs/github-issue-guide.md so it doesn't mention the Severity field.

@Stebalien
Copy link
Member Author

@whyrusleeping standard "timed out waiting for api file show up" bug.

@whyrusleeping
Copy link
Member

@Stebalien that generally means that the daemon failed to start for some reason. Not a good sign

@Stebalien
Copy link
Member Author

@whyrusleeping unfortunately, it's a common race condition in our tests. Daemon takes too long to start (over 5 seconds). There may be some underlying cause bit I have no idea what it is; I've never reproduced this locally.

@whyrusleeping
Copy link
Member

Annoying, but alright.

@whyrusleeping whyrusleeping merged commit 3f2c774 into master Jan 31, 2018
@whyrusleeping whyrusleeping deleted the feat/expand-issue-template branch January 31, 2018 23:11
@ghost ghost removed the status/in-progress In progress label Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants