Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some tests on FreeBSD #4662

Merged
merged 2 commits into from
Feb 7, 2018
Merged

Fix some tests on FreeBSD #4662

merged 2 commits into from
Feb 7, 2018

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Feb 5, 2018

No description provided.

License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@ghost ghost assigned magik6k Feb 5, 2018
@ghost ghost added the status/in-progress In progress label Feb 5, 2018
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo nit.

@@ -15,6 +15,9 @@ sort_rand() {
Linux)
sort -R
;;
FreeBSD)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better just to use Linux|FreeBSD.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magik6k!

@whyrusleeping whyrusleeping merged commit 3106135 into master Feb 7, 2018
@ghost ghost removed the status/in-progress In progress label Feb 7, 2018
@whyrusleeping whyrusleeping deleted the fix/freebsd-tests branch February 7, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants