Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixfs: clean path in DagArchive #4743

Merged
merged 1 commit into from
Mar 23, 2018
Merged

unixfs: clean path in DagArchive #4743

merged 1 commit into from
Mar 23, 2018

Conversation

schomatis
Copy link
Contributor

@schomatis schomatis commented Feb 28, 2018

Clean the path in the function DagArchive that prepares the output in a similar way as the resolver does in Segments.

Fixes #4720.

@Stebalien
Copy link
Member

Stebalien commented Mar 3, 2018

Nice! Mind adding a test case? Probably belongs in test/sharness/t0090-get.sh.

Fixes #4720.

License: MIT
Signed-off-by: Lucas Molas <schomatis@gmail.com>
@schomatis
Copy link
Contributor Author

@Stebalien Thanks for pointing me in the right direction, I copied the structure of the ipfs get (directory) test.

@Kubuxu Kubuxu added this to the go-ipfs 0.4.15 milestone Mar 8, 2018
@Kubuxu Kubuxu added the RFM label Mar 8, 2018
@whyrusleeping whyrusleeping merged commit c44191e into ipfs:master Mar 23, 2018
@whyrusleeping
Copy link
Member

Thanks @schomatis!

@schomatis schomatis deleted the fix/unixfs/dagarchive-path branch March 23, 2018 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipfs get drops containing directory structure in output when <ipfs_path> contains trailing slash ('/')
4 participants