Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mk: add tarball support #4920

Merged
merged 1 commit into from
Apr 20, 2018
Merged

mk: add tarball support #4920

merged 1 commit into from
Apr 20, 2018

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Apr 5, 2018

You can create tarball by running: make go-ipfs-source.tar.gz

License: MIT
Signed-off-by: Jakub Sztandera kubuxu@protonmail.ch

@Kubuxu Kubuxu requested review from Stebalien and magik6k April 5, 2018 16:54
@ghost ghost assigned Kubuxu Apr 5, 2018
@ghost ghost added the status/in-progress In progress label Apr 5, 2018
@Kubuxu Kubuxu added topic/build Topic build and removed status/in-progress In progress labels Apr 5, 2018
@Kubuxu
Copy link
Member Author

Kubuxu commented Apr 5, 2018

Still making small improvements.

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@ghost ghost added the status/in-progress In progress label Apr 5, 2018
@Kubuxu
Copy link
Member Author

Kubuxu commented Apr 5, 2018

I should be finished.
Building out of the GOPATH is quite hard so I gave up on it for time being.

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

In the future, it would be nice to ship a tarball with a simple makefile and all of the gx dependencies rewritten and vendored (useful for distributions).

@Kubuxu Kubuxu added RFM and removed status/in-progress In progress labels Apr 19, 2018
@whyrusleeping whyrusleeping merged commit 922f821 into master Apr 20, 2018
@whyrusleeping whyrusleeping deleted the feat/tarball branch April 20, 2018 14:40
@Kubuxu
Copy link
Member Author

Kubuxu commented Apr 20, 2018

@Stebalien this already vendors gx deps. One can unpack this in the correct place in GOPATH (I wanted to work around this but it ended up being more problematic) and type in make build and ipfs will build without the network.

@Stebalien
Copy link
Member

@Kubuxu where?

@Kubuxu
Copy link
Member Author

Kubuxu commented Apr 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants