cid-sec: fix bitswap strom caused by insecure CIDs #4946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Kubuxu
added
need/review
| for _, c := range ks { | ||
| // hash security | ||
| if err := verifcid.ValidateCid(c); err != nil { | ||
| log.Errorf("unsafe CID (%s) passed to blockService.GetBlocks: %s", c, err) |
There was a problem hiding this comment.
Seems like the right solution to this might be to just add a return of a closed block channel after the error here.
There was a problem hiding this comment.
Not really, a file might have an unsafe block near the end of a file, most of the file should be OK to read. Just the end might be bad.
That is why I sort out the unsafe CIDs and fetch and/or read only the good ones.
Stebalien
approved these changes
Apr 19, 2018
|
@Stebalien I will try. |
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
When we introduced CID security we didn't take into account that bitswap might repeatly try getting the objects from the network if it fails putting them into the blockstore. Solution from this is not requesting those objects from bitswap. The proper solution of failing at CID creation will make in much more cleaner in future. License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Kubuxu
force-pushed
the
fix/cidsec-bitswapstorm
branch
from
5a890bd to
e5ff2c3
Compare
Kubuxu
added
RFM
and removed
status/in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we introduced CID security we didn't take into account that bitswap
might repeatedly try getting the objects from the network if it fails
putting them into the blockstore.
A solution from this is not requesting those objects from bitswap.
The proper solution of failing at CID creation will make it much more
cleaner in future.
License: MIT
Signed-off-by: Jakub Sztandera kubuxu@protonmail.ch