Warning when NoSync setting is set as it does not turn syncing off… #5036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repo/fsrepo/fsrepo.go
Outdated
| @@ -400,6 +400,9 @@ func (r *FSRepo) openDatastore() error { | |||
| } else if r.config.Datastore.Spec == nil { | |||
| return fmt.Errorf("required Datastore.Spec entry missing from config file") | |||
| } | |||
| if r.config.Datastore.NoSync { | |||
| log.Warning("NoSync is no longer effective. Set 'sync' to false. See https://github.com/ipfs/go-ipfs/blob/master/docs/datastores.md#flatfs.") | |||
There was a problem hiding this comment.
Hrm... I think the wording might be clearer as:
"NoSync is now deprecated in favor of datastore specific settings. If you want to disable fsync on flatfs 'sync' to false, See "
|
Thanks for getting to the root of the problem :) |
eginez
changed the title
eginez
force-pushed
the
warningOnSync
branch
2 times, most recently
from
7ece438
to
bc1a0d8
Compare
…pfs#3799 License: MIT Signed-off-by: Esteban Ginez <eginez@gmail.com>
|
Hey @whyrusleeping I think this should be ready to be merged |
whyrusleeping
approved these changes
May 31, 2018
|
Thanks for the ping! and the PR! |
|
no problem |
|
Do I understood the linked issue #3799 right, we ignore Datastore.NoSync? |
|
That's correct Datastore.NoSync is ignored |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… #3799