-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract blockservice and verifcid #5296
Conversation
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
(1) This may complicate #5285 (2) Why are we extracting verifcid? It is temporary and will go away once a more permanent solution lands which I hope to have within a month or so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there is a pressing need for this extraction I would appreciate it if we hold off until #5285 is figured out.
Also is vereifycid needed by someone else? It will go away once #5150 lands.
Blocking to make sure my comments are not lost in the noise. No other reason. If you wish to proceed anyway feel free to disregard my review.
@kevina we can reapply the diffs as needed. This is blocking other things i'm working on. If you want, I can handle porting any conflicting patches. |
Thats okay, we can delete it when we finish that. See the note in the readme for that repo, it explicitly says its temporary. |
Okay. For now I won't rebase #5285 as I am exploring multiple solutions and some of them might require modifying the blockservice (although I would like to avoid it, the alternative might be some nasty modifications to the gc and pinning).
Nevermind: I take it is needed because it is used in the blockservice. |
Ah, yeah. Thats the reason. Forgot to directly mention that |
The extraction is steaming ahead!
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com