Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix two transport related bugs #5417

Merged
merged 3 commits into from
Sep 1, 2018
Merged

fix two transport related bugs #5417

merged 3 commits into from
Sep 1, 2018

Conversation

Stebalien
Copy link
Member

(see the commits)

Otherwise, enabling the QUIC transport will disable the default ones

fixes #5416

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
We explicitly setup listeners but we do this *after* constructing the node.

fixes #5387

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien requested a review from Kubuxu as a code owner August 31, 2018 21:55
@ghost ghost assigned Stebalien Aug 31, 2018
@ghost ghost added the status/in-progress In progress label Aug 31, 2018
No reason not to and it would have caught #5416

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
Copy link
Member Author

Merging now to fix the bugs but we may want to think about libp2p/go-libp2p#409 a bit.

@Stebalien Stebalien merged commit 7b835e9 into master Sep 1, 2018
@ghost ghost removed the status/in-progress In progress label Sep 1, 2018
@Stebalien Stebalien deleted the fix/transports branch February 28, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants