Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Godeps #5440

Merged
merged 2 commits into from
Sep 13, 2018
Merged

remove Godeps #5440

merged 2 commits into from
Sep 13, 2018

Conversation

Stebalien
Copy link
Member

fixes #2722

@ghost ghost assigned Stebalien Sep 7, 2018
@ghost ghost added the status/in-progress In progress label Sep 7, 2018
@Stebalien Stebalien force-pushed the feat/ungodep branch 3 times, most recently from 5bd1033 to 0c43c2c Compare September 7, 2018 22:11
@Stebalien Stebalien mentioned this pull request Sep 7, 2018
Closed
@Stebalien Stebalien force-pushed the feat/ungodep branch 6 times, most recently from 65eeda0 to 8aeaaa5 Compare September 11, 2018 17:47
@Stebalien
remove Godeps
0252710 
fixes #2722

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
Stebalien commented Sep 12, 2018
View reviewed changes
test/3nodetest/Makefile Outdated
@@ -20,7 +19,8 @@ data/filerand: bin/random
./bin/random 50000000 > ./data/filerand

bin/random: $(RANDOMSRC)/**/*.go
go build -o ./bin/random $(RANDOMSRC)/random
go get github.com/jbenet/go-random
go build -o ./bin/random github.com/jbenet/go-random/random
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only real change. It uses go-get, not gx, but, as far as I can tell, we don't use these tests at the moment anyways.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this also https://github.com/ipfs/go-ipfs/pull/5440/files#diff-c8660427d0699f8fe97cb9943c5bd91eR40? I'd just depend on that

magik6k
magik6k reviewed Sep 12, 2018
View reviewed changes
Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the go-random thing, looks good

test/3nodetest/Makefile Outdated
@@ -20,7 +19,8 @@ data/filerand: bin/random
./bin/random 50000000 > ./data/filerand

bin/random: $(RANDOMSRC)/**/*.go
go build -o ./bin/random $(RANDOMSRC)/random
go get github.com/jbenet/go-random
go build -o ./bin/random github.com/jbenet/go-random/random
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this also https://github.com/ipfs/go-ipfs/pull/5440/files#diff-c8660427d0699f8fe97cb9943c5bd91eR40? I'd just depend on that

@Stebalien
use test/bin/random instead of recompiling it
71c65e4 
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
Copy link
Member Author

Isn't this also https://github.com/ipfs/go-ipfs/pull/5440/files#diff-c8660427d0699f8fe97cb9943c5bd91eR40? I'd just depend on that

SGTM. I was stuck trying to figure out the right gx hash (the makefile is independent of our make system) but I realized I can just use the other make system. LGTY?

@Stebalien Stebalien merged commit ce236ab into master Sep 13, 2018
@ghost ghost removed the status/in-progress In progress label Sep 13, 2018
@Stebalien Stebalien deleted the feat/ungodep branch September 13, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k left review comments

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@kevina kevina Awaiting requested review from kevina

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrating away from Godeps
2 participants
@Stebalien @magik6k