-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: allow IPFS_PROFILE to choose the profile for ipfs init
#5473
Conversation
It seems GitCop rejected my commit message as invalid, but I can't find the guidelines for commit messages. My message is 64 characters long, so that shouldn't be the issue. Advice, anyone? |
@akaihola guidance is here: https://github.com/ipfs/go-ipfs/blob/master/contribute.md The commit message is missing the trailers. |
License: MIT Signed-off-by: Antti Kaihola <antti+ipfs@kaihola.fi>
a927083
to
df7c1fc
Compare
@rob-deutsch, thanks for your explanation and sorry for missing those instructions. I now corrected the commit message and force pushed the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not be necessary, but I can never remember the precise rules.
bin/container_daemon
Outdated
ipfs init | ||
case $IPFS_PROFILE in | ||
"") INIT_ARGS= ;; | ||
*) INIT_ARGS=--profile=$IPFS_PROFILE ;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's quote this. That is, INIT_ARGS="..."
.
License: MIT Signed-off-by: Antti Kaihola <antti+ipfs@kaihola.fi>
aebf55b
to
821982e
Compare
@Stebalien afaict, your remaining concern has been resolved (it is marked as outdated in the view), and you might approve this now. |
@whyrusleeping @lgierth any objections? |
Just for the docker stuff? Seems fine to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGMT.
It will do until we need to pass more things as INIT_ARGS
and then we can use bash's array syntax.
Any chance of merging this? Makes infra a lot simpler (no need to have a separate Dockerfile to just override the profile), seems straightforward and been approved. |
Added support for an
IPFS_PROFILE
environment variable in thebin/container_daemon
. The variable, if present, is used withipfs init
to add a--profile=$IPFS_PROFILE
argument which will apply to chosen profile to the newly created configuration.This is useful for automatic IPFS deployments in hosted container environments, e.g. Kubernetes. In such situations, it's essential to use
--profile=server
.Pull request helm/charts#7746 requires this change in order to add the
profile
configurable parameter to the IPFS Helm chart.