Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fuse unmount test #5476

Merged
merged 1 commit into from
Sep 19, 2018
Merged

fix fuse unmount test #5476

merged 1 commit into from
Sep 19, 2018

Conversation

rob-deutsch
Copy link
Contributor

Fuse unmount test uses ipfs instead of ipns, because offline nodes dont actually mount ipns.

Factored out GOOS-aware function to determine unmount command in fuse/mount.

fixed #5475

License: MIT
Signed-off-by: Rob Deutsch rdeutschob@gmail.com

@rob-deutsch rob-deutsch requested a review from Kubuxu as a code owner September 16, 2018 04:54
Fuse unmount test uses ipfs instead of ipns, because offline nodes dont actually mount ipns.

Factored out GOOS-aware function to determine unmount command in fuse/mount.

fixed #5475

License: MIT
Signed-off-by: Rob Deutsch <rdeutschob@gmail.com>
@Stebalien
Copy link
Member

Thanks!

@Stebalien Stebalien merged commit 61f31e5 into ipfs:master Sep 19, 2018
@rob-deutsch rob-deutsch deleted the fix/5475 branch September 20, 2018 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestExternalUnmount fails unmounting ipns
2 participants