-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug-guide.md added memory statistics command #5546
Conversation
Thanks @rob-deutsch! Could you add a link to the |
Thanks @schomatis, resubmitted with suggested additions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
docs/debug-guide.md
Outdated
@@ -84,6 +86,10 @@ about `go tool pprof`. My go-to method of analyzing these is to run the `web` | |||
command, which generates an SVG dotgraph and opens it in your browser. This is | |||
the quickest way to easily point out where the hot spots in the code are. | |||
|
|||
### Analysing vars and memory statistics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could you also add an entry in the "Table of Contents" above pointing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drat, my bad, will do
... I also noticed (and fixed) the inconsistent spelling of analyse/analyze, just to make it a tad neater. |
I think they are both right but "analyze" is the accepted American spelling. |
License: MIT Signed-off-by: Rob Deutsch <rdeutschob@gmail.com>
In the case of ambiguity I tend to prefer British English, but some after some Googling I learned that US English is generally accepted for this kind of purpose. Resubmitted with US English and a small frown of disapproval 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the "stack dump" entry also! Beyond the call of duty 🎖️
There is also a much simpler option for non-linux folks to download most of the info: going to Not blocking this PR in any regard, just mentioning it as I discovered it recently. EDIT: localhost:5001/debug/ -> localhost:5001/debug/pprof/ |
I'm getting a 404 error on |
Sorry: Unfortunately no |
This would've been valuable to me while investigating #5530.
I discovered that more debug commands are also available, but I don't know enough about them to add them myself (e.g.
debug/pprof-mutex
,debug/metrics/prometheus
).