Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sharness race in directory_size if file is removed #5586

Merged
merged 1 commit into from
Oct 18, 2018
Merged

fix: sharness race in directory_size if file is removed #5586

merged 1 commit into from
Oct 18, 2018

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Oct 11, 2018

No description provided.

@ghost ghost assigned Kubuxu Oct 11, 2018
@ghost ghost added the status/in-progress In progress label Oct 11, 2018
@Kubuxu Kubuxu requested review from Stebalien and djdv October 11, 2018 08:36
@Kubuxu Kubuxu force-pushed the fix/sharness/stat-race branch 2 times, most recently from 50918a4 to 9db2621 Compare October 11, 2018 08:37
Stebalien
Stebalien requested changes Oct 12, 2018
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test can still fail as the expected size may not equal the actual size (due to this extra temporary file). We should shut down the daemon when we run this.

@Kubuxu
fix(sharness): gc repo size tests failing
a4fab7f 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu Kubuxu requested a review from Stebalien October 15, 2018 08:27
@Stebalien Stebalien merged commit 9cdbb1e into master Oct 18, 2018
@ghost ghost removed the status/in-progress In progress label Oct 18, 2018
@Stebalien Stebalien deleted the fix/sharness/stat-race branch October 18, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@djdv djdv Awaiting requested review from djdv

Assignees

@Kubuxu Kubuxu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kubuxu @Stebalien