Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd/gc): Run func does not return error when Emit func returns error #5687

Merged
merged 1 commit into from
Oct 29, 2018
Merged

fix(cmd/gc): Run func does not return error when Emit func returns error #5687

merged 1 commit into from
Oct 29, 2018

Conversation

qiwaa
Copy link
Contributor

@qiwaa qiwaa commented Oct 29, 2018

License: MIT
Signed-off-by: chenminjian 727180553@qq.com

License: MIT
Signed-off-by: chenminjian <727180553@qq.com>
@Stebalien
Copy link
Member

(we're going to have to cut an RC2 anyways so we might as well merge this (it is a regression)).

@Stebalien Stebalien merged commit 8008246 into ipfs:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants