Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move persistent datastores to plugins #5695

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Move persistent datastores to plugins #5695

merged 2 commits into from
Nov 5, 2018

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Oct 30, 2018

Mostly because #5694 (wasm support)

Since this is using preload it shouldn't affect binary size / performance / compatibility, and just allows to easily disable modules.

@magik6k magik6k requested a review from Kubuxu as a code owner October 30, 2018 03:30
@ghost ghost assigned magik6k Oct 30, 2018
@ghost ghost added the status/in-progress In progress label Oct 30, 2018
@magik6k magik6k force-pushed the misc/pulgin-datastores branch 2 times, most recently from 01b9962 to ef2be20 Compare October 30, 2018 03:32
@magik6k magik6k requested a review from djdv October 30, 2018 03:32
djdv
djdv approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@djdv djdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initialized a flatfs and badger node with this branch and made them transfer data with each other, without issues.
Code seems like a straightforward migration.

👍 on separating modules out and making them plugins where possible.

@ghost ghost assigned Stebalien Nov 2, 2018
@Stebalien
Copy link
Member

Jenkins doesn't seem to like this change.

@magik6k
Copy link
Member Author

magik6k commented Nov 4, 2018

Fixed

@magik6k
Move datastores to plugins
c154f7f 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k
Load static plugins in init
5bfb886 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@Stebalien Stebalien merged commit c5c4379 into master Nov 5, 2018
@Stebalien Stebalien deleted the misc/pulgin-datastores branch November 5, 2018 15:06
@ghost ghost removed the status/in-progress In progress label Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@djdv djdv djdv approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@Stebalien Stebalien

@magik6k magik6k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magik6k @Stebalien @djdv