error on resolving non-terminal paths #5705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't the *correct* fix but it (mostly) restores the previous behavior. Note 1: It *also* fixes resolution of `/ipld` paths by avoiding `path.FromCid`. Note 2: This does not preserve the error. That was a DagCBOR specific error that has nothing to do with the issue. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ghost
assigned 
|
Alternative to #5704 that mostly preserves the current behavior. In retrospect, I actually prefer just breaking this now (we're not going to pass the js-ipfs-api tests either way). |
magik6k
reviewed
Oct 30, 2018
core/commands/resolve.go
Outdated
| @@ -135,9 +135,11 @@ Resolve the value of an IPFS DAG path: | |||
| return err | |||
| } | |||
|
|
|||
| c := rp.Cid() | |||
| if rp.Remainder() != "" { | |||
| return fmt.Errorf("path does not end on a dag-node boundary") | |||
There was a problem hiding this comment.
We may want to keep the original error too because https://github.com/ipfs/interface-ipfs-core/pull/385/files#diff-8ce9a93c2e33e2c37099701b755064a3L85
There was a problem hiding this comment.
i.e. found non-link at given path
There was a problem hiding this comment.
That error message is just a side-effect of DagCBOR. But yeah, we can keep it for now.
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
magik6k
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't the correct fix but it (mostly) restores the previous behavior.
Note 1: It also fixes resolution of
/ipldpaths by avoidingpath.FromCid.Note 2: This does not preserve the error. That was a DagCBOR specific error that has nothing to do with the issue.