Show hash on gateway #5830
Merged
Show hash on gateway #5830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there an associated github.com/ipfs/dir-index-html PR? |
|
@Stebalien yes: ipfs/dir-index-html#21. sorry, ran out of time yesterday |
jackloughran
force-pushed
the
feat/gateway/always-show-hash
branch
from
51f4841
to
b19ca86
Compare
Stebalien
force-pushed
the
feat/gateway/always-show-hash
branch
from
b19ca86
to
e660848
Compare
ghost
assigned 
Stebalien
requested changes
Dec 20, 2018
core/corehttp/gateway_handler.go
Outdated
| @@ -347,11 +347,17 @@ func (i *gatewayHandler) getOrHeadHandler(ctx context.Context, w http.ResponseWr | |||
| } | |||
| } | |||
|
|
|||
| var hash string | |||
| if !strings.Contains(originalUrlPath, "ipfs") { | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
(note: I've updated dir-index-html and rebased this) |
Stebalien
force-pushed
the
feat/gateway/always-show-hash
branch
from
815b1c1
to
de2b121
Compare
|
@kevina, @magik6k, and/or @swedneck I'd like someone else to sign off on this as both @jackloughran and I participated a bit too much in the design to be neutral third parties. |
Stebalien
added
need/review
Stebalien
approved these changes
Jan 4, 2019
magik6k
approved these changes
Jan 4, 2019
|
I can't judge the code, but the screenshots look great. |
|
@Stebalien thanks for making that change. i got sidetracked with the holidays. looks like this is good to go, but i'd be happy to do anything else over the weekend. |
Change the template handler to pass the hash to the directory listing template if the original url doesn't contain the hash. The directory listing template will display the hash in grey under the original url if the hash is passed to it. License: MIT Signed-off-by: Jack Loughran <j@ckloughran.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
force-pushed
the
feat/gateway/always-show-hash
branch
from
de2b121
to
65fc4b4
Compare
|
Thanks @jackloughran for implementing this and @swedneck for the proposal! |
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
…ys-show-hash Show hash on gateway This commit was moved from ipfs/kubo@f98652c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Stebalien this will show the hash if the request doesn't have ipfs in the url:
fixes #5724