Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: duplicate default helptext in name publish #5960

Merged
merged 1 commit into from
Feb 1, 2019
Merged

docs: duplicate default helptext in name publish #5960

merged 1 commit into from
Feb 1, 2019

Conversation

djdv
Copy link
Contributor

@djdv djdv commented Feb 1, 2019

-k, --key string - Name of the key to be used or a valid PeerID, as listed by 'ipfs key list -l'. Default: Default: self..

@djdv
docs: duplicate default helptext
8111214 
License: MIT
Signed-off-by: Dominic Della Valle <ddvpublic@gmail.com>
@djdv djdv requested a review from Kubuxu as a code owner February 1, 2019 14:20
@ghost ghost assigned djdv Feb 1, 2019
@ghost ghost added the status/in-progress In progress label Feb 1, 2019
@djdv djdv changed the title docs: duplicate default helptext in name docs: duplicate default helptext in name publish Feb 1, 2019
@Kubuxu
Copy link
Member

Kubuxu commented Feb 1, 2019

Apart from tests randomly failing. A command in line 77 also uses <<default>>, it looks like <> is not supported so it should be resolved too.

@djdv
Copy link
Contributor Author

djdv commented Feb 1, 2019

This is kind of strange.
The text for -t (line 77) seems to be working as intended and not duplicating "Default:", but does use the same pattern that causes this problem for -k. I'm not sure what's going on here.

On my machine with this patch it looks like this
image

Kubuxu
Kubuxu approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it seems like it is a reminder from an earlier generation of <<default>>.
SGWM

@Stebalien Stebalien merged commit 8a0c01c into ipfs:master Feb 1, 2019
@ghost ghost removed the status/in-progress In progress label Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu approved these changes

Assignees

@djdv djdv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djdv @Kubuxu @Stebalien