Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmd/mv): dst filename error #5964

Merged
merged 1 commit into from
Feb 14, 2019
Merged

fix(cmd/mv): dst filename error #5964

merged 1 commit into from
Feb 14, 2019

Conversation

qiwaa
Copy link
Contributor

@qiwaa qiwaa commented Feb 2, 2019

#5963

License: MIT
Signed-off-by: chenminjian 727180553@qq.com

@qiwaa qiwaa requested a review from Kubuxu as a code owner February 2, 2019 05:17
@magik6k
Copy link
Member

magik6k commented Feb 3, 2019

(go-mfs PR - ipfs/go-mfs#62)

magik6k
magik6k reviewed Feb 3, 2019
View reviewed changes
Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to have a test for this (for example in test/sharness/t0250-files-api.sh)

@ghost ghost assigned Stebalien Feb 8, 2019
@ghost ghost added the status/in-progress In progress label Feb 8, 2019
@Stebalien
Copy link
Member

Dropped the gx update as mfs has already been updated. Kept the test.

Stebalien
Stebalien requested changes Feb 8, 2019
View reviewed changes
test/sharness/t0250-files-api.sh Outdated Show resolved Hide resolved
@qiwaa
test(cmd/mv): add test for files mv cmd
6271dba 
License: MIT
Signed-off-by: chenminjian <727180553@qq.com>
@Stebalien Stebalien merged commit 88a54fc into ipfs:master Feb 14, 2019
@ghost ghost removed the status/in-progress In progress label Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k left review comments

@Stebalien Stebalien Stebalien approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qiwaa @magik6k @Stebalien