fix a few interop test issues #6004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
(interop) License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ghost
assigned
Stebalien
commented
Feb 19, 2019
core/commands/cat.go
Outdated
| case files.Directory: | ||
| return nil, 0, iface.ErrIsDir | ||
| case *files.Symlink: | ||
| // TODO: Consider returning "error not supported"? |
There was a problem hiding this comment.
We can handle this later, IMO.
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Kubuxu
approved these changes
Feb 19, 2019
Stebalien
force-pushed
the
fix/interop-tests
branch
from
e94f83f
to
229f5f3
Compare
Kubuxu
approved these changes
Feb 19, 2019
magik6k
reviewed
Feb 19, 2019
|
|
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
* Updates go-ipfs-cmds to try to get the tests to pass on travis. * While we're at it, fix duplicate gx deps. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interop tests passed but the interface tests didn't.
config.bootstrap rm.Other issues: