fix ls command to use the new coreinterface types #6051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
added
the
status/blocked
magik6k
approved these changes
Mar 5, 2019
| case cid.Raw: | ||
| // No need to check with raw leaves | ||
| lnk.Type = coreiface.TFile | ||
| lnk.Size = lnk.Link.Size | ||
| lnk.Size = linkres.Link.Size | ||
| case cid.DagProtobuf: |
There was a problem hiding this comment.
This should also fill lnk.Target for symlinks.
|
Sharness is not happy. |
Stebalien
force-pushed
the
feat/nicer-ls
branch
5 times, most recently
from
c38362a
to
f39b9a4
Compare
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
See: ipfs/interface-go-ipfs-core#14 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
removed
the
status/blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: ipfs/interface-go-ipfs-core#14