test(coreapi): use a thread-safe datastore everywhere #6222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
I'll test it. |
|
It fixes the race condition. There's still another failure but it might be unrelated: |
|
ipfs/interface-go-ipfs-core#28 (actually due to the go-libp2p-peer change and a faulty test) |
magik6k
approved these changes
Apr 16, 2019
fixes libp2p/go-libp2p-kad-dht#321 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
guseggert
pushed a commit
to ipfs/boxo
that referenced
this pull request
Dec 6, 2022
And fix for peer ID formatting changes. fixes ipfs/kubo#6222 (comment) This commit was moved from ipfs/interface-go-ipfs-core@29b26f5
guseggert
pushed a commit
to ipfs/boxo
that referenced
this pull request
Mar 15, 2023
And fix for peer ID formatting changes. fixes ipfs/kubo#6222 (comment) This commit was moved from ipfs/interface-go-ipfs-core@29b26f5
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
And fix for peer ID formatting changes. fixes ipfs/kubo#6222 (comment) This commit was moved from ipfs/interface-go-ipfs-core@29b26f5
hacdias
pushed a commit
that referenced
this pull request
Nov 29, 2023
And fix for peer ID formatting changes. fixes #6222 (comment) This commit was moved from ipfs/interface-go-ipfs-core@29b26f5 This commit was moved from ipfs/boxo@d493b70
hacdias
pushed a commit
that referenced
this pull request
Nov 29, 2023
And fix for peer ID formatting changes. fixes #6222 (comment) This commit was moved from ipfs/interface-go-ipfs-core@29b26f5 This commit was moved from ipfs/boxo@d493b70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes libp2p/go-libp2p-kad-dht#321
cc @anacrolix