core/corehttp/gateway_handler: pass a request ctx instead of the node #6244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
requested changes
Apr 23, 2019
core/corehttp/gateway_handler.go
Outdated
| @@ -542,7 +537,7 @@ func (i *gatewayHandler) deleteHandler(w http.ResponseWriter, r *http.Request) { | |||
|
|
|||
| var newnode *dag.ProtoNode = pbnd | |||
| for j := len(pathNodes) - 2; j >= 0; j-- { | |||
| if err := i.node.DAG.Add(ctx, newnode); err != nil { | |||
| if err := i.node.DAG.Add(tctx, newnode); err != nil { | |||
There was a problem hiding this comment.
Actually, this wasn't a bug. The minute timeout is for fetching the node as that may involve a network operation. Here, we don't really want to time out at all (although the global hour timeout is fine).
There was a problem hiding this comment.
Ok, got it. I'll make usage of "tctx" more explicit. Just put it into a new method or a "block".
… ctx License: MIT Signed-off-by: Georgij Tolstov <tolstov.georgij@gmail.com>
reinerRubin
force-pushed
the
fix/core/4607-pass-context
branch
from
c6e52ef
to
d2836de
Compare
Stebalien
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have tried to solve this bug [1].
idk, about "tctx" in the "deleteHandler". After tctx is defined some calls after still use original ctx. I have assumed that it is bug and changed to "tctx"
1 - #4607