Invert constructor config handling #6276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
ghost
assigned License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
magik6k
force-pushed
the
feat/core-cfg-handling
branch
from
5f194ed
to
e133058
Compare
Stebalien
approved these changes
Apr 29, 2019
| fx.Provide(libp2p.AddrsFactory(cfg.Addresses.Announce, cfg.Addresses.NoAnnounce)), | ||
| fx.Provide(libp2p.SmuxTransport(bcfg.getOpt("mplex"))), | ||
| fx.Provide(libp2p.Relay(cfg.Swarm.DisableRelay, cfg.Swarm.EnableRelayHop)), | ||
| fx.Invoke(libp2p.StartListening(cfg.Addresses.Swarm)), |
There was a problem hiding this comment.
We can handle this later but I wonder if this should go elsewhere; somewhere higher up the stack.
|
|
||
| if quic { | ||
| opts.Opts = append(opts.Opts, libp2p.DefaultTransports, libp2p.Transport(libp2pquic.NewTransport)) | ||
| } |
There was a problem hiding this comment.
Small note: Once libp2p starts using fx, this will go away. At that point, we should be able to just pull in the transports group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6232
The diff is slightly larger that I initially thought it would be, but it looks reasonably good (there is still room for improvement, but I wanted to keep the PR size down)