repeat gateway subdomain test for all key types #7542
Conversation
There was a problem hiding this comment.
Rerunning the whole test twice seems like overkill (also Github makes it difficult to do the diff). Also, it makes it sort of a pain to figure out where the error is since you have to figure out which loop it's running through to identify your test error, it's not the end of the world but also fairly avoidable here,
We just need to duplicate all the places where we test IPNS_IDv0, IPNS_IDv1, and I guess IPNS_IDv1_DAGPB twice to use IPNS_IDv{X}RSA and IPNS_IDv{X} Ed25519.
| RSA_KEY=$(ipfs key gen -f=b58mh --type=rsa --size=2048 test_key_rsa | head -n1 | tr -d "\n") | ||
| RSA_IPNS_IDv0=$(echo "$RSA_KEY" | ipfs cid format -v 0) | ||
| RSA_IPNS_IDv1=$(echo "$RSA_KEY" | ipfs cid format -v 1 --codec libp2p-key -b base36) | ||
| RSA_IPNS_IDv1_DAGPB=$(echo "$RSA_IPNS_IDv0" | ipfs cid format -v 1 -b base36) |
There was a problem hiding this comment.
Should the "ipfs cid" command have a "--codec protobuf" flag like below?
There was a problem hiding this comment.
It's not necessary since when --codec isn't specified it leaves the codec alone and the codec for cidv0 (which RSA keys are) is always DagPB.
I'm not sure whether making this more solid by adding --codec protobuf would make us more or less likely to catch errors.
No description provided.