-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(ipfs.add): flag behavior around cidv1 #8457
Conversation
@lidel you got the things the wrong way around. My issue is that CIDv1 implies raw leaf unless the user specify it otherwise. ( I hope this clears it out :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comment
By the way, when I've said : "Your PR explain that raw leaf implies CIDv1 which is false" that is partialy wrong. |
Co-authored-by: Adin Schmahmann <adin.schmahmann@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied suggestions from review and dropped (experimental)
from cid-version
and raw-leaves
. CIDv1 has been used in production for more than a year now, no need to keep this until it becomes the default.
I sympathize with @Jorropo that behavior is confusing, but realistically the best we can do to solve it is to continue work towards CIDv1 as default (#4143, we have ipfs/fs-repo-migrations#95 scheduled to land by EOY).
Let's merge this as-is and invest time towards CIDv1.
Closes #8396
@Jorropo would this make things clean enough?