Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enabling pubsub and ipns-pubsub via config flags #8510

Merged
merged 11 commits into from
Nov 30, 2021
Merged

feat: enabling pubsub and ipns-pubsub via config flags #8510

merged 11 commits into from
Nov 30, 2021

Conversation

jwh
Copy link
Contributor

@jwh jwh commented Oct 13, 2021

@aschmahmann
Copy link
Contributor

@jwh it looks like CI isn't running. Is it possible you have a CircleCI account that is following your fork rather than ipfs/go-ipfs?

From https://circleci.com/docs/2.0/oss/#build-pull-requests-from-forked-repositories

Note: If a user submits a pull request to your repository from a fork, but no pipeline is triggered, then the user most likely is following a project fork on their personal account rather than the project itself of CircleCi, causing the jobs to trigger under the user’s personal account and not the organization account. To resolve this issue, have the user unfollow their fork of the project on CircleCI and instead follow the source project. This will trigger their jobs to run under the organization when they submit pull requests.

cmd/ipfs/daemon.go Outdated Show resolved Hide resolved
@lidel lidel changed the title Allow pubsub and namesys-pubsub to be enabled via config feat: enabling pubsub via config flags Oct 27, 2021
@lidel lidel changed the title feat: enabling pubsub via config flags feat: enabling pubsub and ipns-pubsub via config flags Oct 27, 2021
@lidel lidel marked this pull request as ready for review October 27, 2021 20:48
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added docs, and sharness tests to ensure we check both ways of enabling pubsub.
Let's wait for CI. If there are still issues, I'll open this as a new PR. sharness is green

go.mod Outdated Show resolved Hide resolved
core/node/libp2p/nat.go Outdated Show resolved Hide resolved
@lidel lidel self-assigned this Oct 28, 2021
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self:

  • sharness tests both ways of enabling pubsub (cli+config), both pass
  • sharness tests both ways of enabling ipns-over-pubsub (cli+config), both pass
  • needs to be switched to go-ipfs-config release with feat: pubsub and ipns pubsub flags go-ipfs-config#145 before this is merged

@lidel lidel mentioned this pull request Nov 23, 2021
80 tasks
@lidel lidel added this to the go-ipfs 0.11 milestone Nov 23, 2021
core/node/groups.go Outdated Show resolved Hide resolved
cmd/ipfs/daemon.go Show resolved Hide resolved
cmd/ipfs/daemon.go Outdated Show resolved Hide resolved
cli flag should override both config and namesys flag
@aschmahmann aschmahmann merged commit 029d82c into ipfs:master Nov 30, 2021
@lidel lidel mentioned this pull request Dec 6, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants