-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate go-dag-jose plugin #8569
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
@aschmahmann suggests that we should also add a smoke tests that all the wiring works, by using a sharness test: https://github.com/ipfs/go-ipfs/blob/master/test/sharness/t0280-plugin-git.sh is an example for git. Can we quickly add something similar for this? |
Had to wrangle bash into submission so took a little longer than I expected. Please take a look @aschmahmann and @warpfork. Also, I do see the failing CI tests so will work on fixing them ASAP. |
@smrz2001: @aschmahmann is going to rebase first since it's quite possible the CI failures aren't your fault. It looks like you may have forked at an inopportune time while we were getting interoperability tests to pass. |
@smrz2001 I don't have permissions to push to your branch can you give me permissions (https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork) or do the rebase yourself? |
Thanks, @BigLep. Hey @aschmahmann, just looking at this. I can't find that checkbox for some reason 😕 Give me a couple min to figure this out, otherwise I'll try the rebase myself. |
omfg, I hate WSL (Windows Subsystem for Linux) sometimes. One of the submodules keeps messing up my attempts to do anything because it shows up as a diff when there is none. I just added you to my fork, @aschmahmann. |
This commit is not functional on its own. Some features are missing upstream. Someone will need to take this as a guide and do additional work to make it complete and functional, once the needed upstream features are available.
🥳 🎉 Thanks @aschmahmann for the quick turnaround! |
Integrate
go-dag-jose
pluginDescription
This PR integrates the
go-dag-jose
plugin into IPFS.How Has This Been Tested?
ipfs dag put --store-codec dag-jose
andipfs dag get
work correctlydag-jose
fixtures work correctlyDefinition of Done
go-dag-jose
References:
dag-jose
implementation using IPLD schema/code generation ceramicnetwork/go-dag-jose#23