From 9c823b87ef74aa3e2529d4acc398cdb890143698 Mon Sep 17 00:00:00 2001 From: Oli Evans Date: Wed, 19 Sep 2018 10:10:46 +0100 Subject: [PATCH 1/2] fix: make global toggle checkbox less ambiguous A checkbox label should say what it will do if it is checked. License: MIT Signed-off-by: Oli Evans --- add-on/_locales/en/messages.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/add-on/_locales/en/messages.json b/add-on/_locales/en/messages.json index 04339dc04..13e38c672 100644 --- a/add-on/_locales/en/messages.json +++ b/add-on/_locales/en/messages.json @@ -8,7 +8,7 @@ "description": "A label for IPFS icon (panel_headerIpfsNodeIconLabel)" }, "panel_headerActiveToggleTitle": { - "message": "Global toggle: activate or suspend all IPFS integrations", + "message": "Global toggle: Suspend all IPFS integrations", "description": "A label for an embedded IPFS node (panel_headerActiveToggleTitle)" }, "panel_statusOffline": { From 602769e8ed7e7adfe57c1c59c131f967390e926c Mon Sep 17 00:00:00 2001 From: Marcin Rataj Date: Wed, 19 Sep 2018 12:25:15 +0200 Subject: [PATCH 2/2] fix: checkbox for panel_headerActiveToggleTitle --- add-on/src/options/forms/global-toggle-form.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/add-on/src/options/forms/global-toggle-form.js b/add-on/src/options/forms/global-toggle-form.js index a55a1aa40..f1f9d1487 100644 --- a/add-on/src/options/forms/global-toggle-form.js +++ b/add-on/src/options/forms/global-toggle-form.js @@ -5,11 +5,11 @@ const browser = require('webextension-polyfill') const html = require('choo/html') function globalToggleForm ({ active, onOptionChange }) { - const toggle = onOptionChange('active') + const toggle = onOptionChange('active', checked => !checked) return html`
-