Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch ipfs-webui preload to CAR fetch from gateway #1102

Closed
lidel opened this issue Nov 16, 2022 · 1 comment
Closed

Switch ipfs-webui preload to CAR fetch from gateway #1102

lidel opened this issue Nov 16, 2022 · 1 comment
Labels
exp/intermediate Prior experience is likely helpful kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up

Comments

@lidel
Copy link
Member

lidel commented Nov 16, 2022 •
edited
Loading

Extracted from ipfs-companion/pull/1101

add-on/src/lib/precache.js has some ancient code that was preloading webui as a TAR.
We now have verifiable CAR fetch from gateways, should remove use of /api/v0/get,
and refactor this logic to use CARs (see docs below).

Ref.
@lidel lidel added kind/maintenance Work required to avoid breaking changes or harm to project's status quo exp/intermediate Prior experience is likely helpful P1 High: Likely tackled by core team if no one steps up labels Nov 16, 2022
@lidel lidel mentioned this issue Nov 16, 2022
Merged
@lidel
Copy link
Member Author

lidel commented Nov 22, 2022

No longer needed – upon closer look #1101 does preload via ipfs.dag.get and we no longer need to replace TAR – what was used by old Brave (when we used js-ipfs instead go-ipfs and there was no DHT in js-ipfs)

@lidel lidel closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/intermediate Prior experience is likely helpful kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
IPFS-GUI (PL EngRes)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lidel