Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer build does not work on MS Windows #796

Open
5 tasks
lidel opened this issue Oct 16, 2019 · 0 comments
Open
5 tasks

Developer build does not work on MS Windows #796

lidel opened this issue Oct 16, 2019 · 0 comments
Assignees
Labels
kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo

Comments

@lidel
Copy link
Member

lidel commented Oct 16, 2019

extracted from #782

Problem

Docker-based release builds runn in linux container, but regular yarn dev-build does not, and $RELEASE_CHANNEL variable is not set correctly on Windows.

Fix

Just avoid shell scripting, move to JS. In this case:

  • refactor package.json, simplify the way vendor-specific bundles are generated.
    • Create JS script that reads ENV variable and takes care of both manifest update and merging
    • Remove ci/update-manifest.sh
    • Remove manifest merging in CLI
    • Ensure manifest gets updated during bundle: tasks
@lidel lidel added kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo labels Oct 16, 2019
@lidel lidel self-assigned this Oct 16, 2019
@galargh galargh moved this to To do in IPFS-GUI (PL EngRes) Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo
Projects
No open projects
Status: Needs Grooming
Development

No branches or pull requests

1 participant