Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim down unused ipfs-css assets #881

Closed
lidel opened this issue May 15, 2020 · 2 comments · Fixed by #882
Closed

Trim down unused ipfs-css assets #881

lidel opened this issue May 15, 2020 · 2 comments · Fixed by #882
Assignees
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/maintenance Work required to avoid breaking changes or harm to project's status quo P0 Critical: Tackled by core team ASAP

Comments

@lidel
Copy link
Member

lidel commented May 15, 2020

After switching to ipfs-css v1.x we ballooned the package a bit:

v2.11 (last stable):

10M ipfs_companion-2.11.0_chromium.zip 
4M  ipfs_companion-2.11.0_firefox.zip

v2.11.0.918 (latest beta):

19M   ipfs_companion_beta_ece3e0b_-2.11.0.918_chromium.zip
12M   ipfs_companion_beta_ece3e0b_-2.11.0.918_firefox.zip

Low hanging fruit is to remove fonts and icons that are not used:

 12.2 MiB  /ui-kit/fonts
564.0 KiB  /ui-kit/icons

Another problem is the size of WebUI, which is for now only bundled with Chromium/Brave:

 21.6 MiB  /dist/precache/webui.tar

But that's something we need to tackle upstream.

@lidel lidel added help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo exp/novice Someone with a little familiarity can pick up P0 Critical: Tackled by core team ASAP effort/hours Estimated to take one or several hours labels May 15, 2020
@jessicaschilling
Copy link
Contributor

I was actually thinking of using the power and gear icons from ipfs-css in the main control screen, so thanks for the heads up ...

@lidel
Copy link
Member Author

lidel commented May 18, 2020

@jessicaschilling I mean, some fonts and some icons are being used, we just need to find a way of removing unused ones. In the past, the surface was small, and we used CSS directly, probably should start processing it as part of the build – I will look into this today, as I need to solve it before shipping to stable channel.

(I'd love us to use power and gear as they are in ipfs-css instead of custom versions we have right now)

@lidel lidel self-assigned this May 18, 2020
@lidel lidel removed the help wanted Seeking public contribution on this issue label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/maintenance Work required to avoid breaking changes or harm to project's status quo P0 Critical: Tackled by core team ASAP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants